[ui-core]: add onSuccess and onError callback for useLoadData hook #3849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramprasadagarwal
requested review from
tabraiz12,
bjornalm,
Harshg999,
nidhibhatg and
ananya-agarwal
bjornalm
approved these changes
Sep 17, 2024
tabraiz12
reviewed
Sep 17, 2024
| @@ -61,8 +66,16 @@ const useLoadData = <T, U = unknown>(url?: string, options?: IOptions<T, U>): IU | |||
| const fetchUrl = localOptions?.urlPrefix ? `${localOptions.urlPrefix}${url}` : url; | |||
| const response = await get<T, U>(fetchUrl, localOptions?.params, fetchOptions); | |||
| setData(response); | |||
| setError(undefined); | |||
There was a problem hiding this comment.
setError not required as it is set above.
There was a problem hiding this comment.
this is required in the edge case.
- First call made which resulted in error. Hence error is set to non-null and data is unchanged.
- Second call is made either by triggering
refetchfunction or by changing and of theoptions. When its a success, the old error state is still set to non-null and data after second call is also set to non-null.
There was a problem hiding this comment.
Apologies, I over-sighted the setError at line 63.
Thanks for flagging. I have removed it
tabraiz12
reviewed
Sep 17, 2024
| } catch (error) { | ||
| setError(error instanceof Error ? error : new Error(error)); | ||
| setData(undefined); |
There was a problem hiding this comment.
old data will be removed do we want that?
lets say there is table already loaded and we are calling useLoadData hook in a interval. in case of api fails, we can throw error but should we remove the tables data?
There was a problem hiding this comment.
Ah, this makes sense.
tabraiz12
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
How was this patch tested?
Please review Hue Contributing Guide before opening a pull request.